Checked commits DavidResende0/manageiq-ui-classic@2859537~...8ac0b50 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
13 files checked, 11 offenses detected

app/views/miq_request/_request_dialog_details.html.haml

• ⚠️ - Line 31 - Style/ClassEqualityComparison: Use instance_of?(Integer) instead of comparing classes.
• ⚠️ - Line 32 - Style/HashEachMethods: Use each_value instead of values.each.
• ⚠️ - Line 34 - Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.
• ⚠️ - Line 38 - Style/HashEachMethods: Use each_value instead of values.each.
• ⚠️ - Line 40 - Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.
• ⚠️ - Line 45 - Style/HashEachMethods: Use each_value instead of values.each.
• ⚠️ - Line 47 - Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.

app/views/service/service_reconfigure.html.haml

• ⚠️ - Line 1 - Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
• ⚠️ - Line 1 - Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
• ⚠️ - Line 2 - Layout/TrailingEmptyLines: Final newline missing.

app/views/shared/dialogs/_dialog_user.html.haml

• ⚠️ - Line 2 - Avoid using instance variables in partials views

Separated the fixes from the form conversion and made a new pr here: #8953

This pull request is not mergeable. Please rebase and repush.

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

hey @DavidResende0 , could you please rebase this PR?
Also when you find time, could you please update the ToDo List?
Thanks

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).